fix: normalize container registry username to lowercase#2358
Open
fix: normalize container registry username to lowercase#2358
Conversation
Docker registry names must be lowercase. This fix normalizes the username to lowercase before sending to the API, preventing the error: 'invalid tag ghcr.io/Guimove/...: repository name must be lowercase' This applies to all registry types, not just GitHub Container Registry.
Member
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #2358 +/- ##
===========================================
- Coverage 52.38% 48.79% -3.60%
===========================================
Files 381 827 +446
Lines 7949 17267 +9318
Branches 2432 5133 +2701
===========================================
+ Hits 4164 8425 +4261
- Misses 3008 7255 +4247
- Partials 777 1587 +810
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker registry names must be lowercase. This fix normalizes the username to lowercase before sending to the API, preventing the error: 'invalid tag ghcr.io/Guimove/...: repository name must be lowercase'
This applies to all registry types, not just GitHub Container Registry.
Summary
Issue:
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release